added the option for the plugin to render hypothesis elements as links#23
Open
anotherdish wants to merge 1 commit intoc6p:mainfrom
Open
added the option for the plugin to render hypothesis elements as links#23anotherdish wants to merge 1 commit intoc6p:mainfrom
anotherdish wants to merge 1 commit intoc6p:mainfrom
Conversation
…s a link that will open up the element in the browser
Author
|
also, im assuming that the reason for putting the
|
Owner
|
Sorry for being this late, I missed the PRs. I like the idea. But, it has to wait a little bit more. I'm planning to make some changes to how annotations are rendered. It will be similar to how logseq renders PDF annotations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basically this code just implements an option that allows the hypothesis items that get rendered to be clickable links that take you directly to the source item
this allows us to do things like what is possible with the logseq pdf annotations, where the highlights are clickable and take you directly to the line in the PDF